Bukama commented on code in PR #997:
URL:
https://github.com/apache/maven-compiler-plugin/pull/997#discussion_r2541578493
##########
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##########
@@ -1775,7 +1781,11 @@ private void writeDebugFile(final ToolExecutor executor,
final Options configura
final var commandLine = new StringBuilder("For trying to compile from
the command-line, use:");
Path dir = basedir;
if (dir != null) { // Should never be null, but it has been observed
with some Maven versions.
Review Comment:
I don't get this comment in together with the if statement.
The comment says that dir should never be null, but it was observed, so I
would assume the if handles the one path and an else path the rare, but
observed, path if it is. But I don't see an else to handle this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
