elharo commented on code in PR #11453:
URL: https://github.com/apache/maven/pull/11453#discussion_r2535985017
##########
impl/maven-cli/src/test/java/org/apache/maven/cling/invoker/mvnup/goals/ApplyTest.java:
##########
@@ -124,7 +125,7 @@ void shouldInheritBehaviorFromAbstractUpgradeGoal() {
// This test verifies that Apply inherits the model version logic
from AbstractUpgradeGoal
// The actual logic is tested in AbstractUpgradeGoalTest
// Here we just verify that Apply is properly configured as a
subclass
- assertTrue(applyGoal instanceof AbstractUpgradeGoal, "Apply should
extend AbstractUpgradeGoal");
+ assertInstanceOf(AbstractUpgradeGoal.class, applyGoal, "Apply
should extend AbstractUpgradeGoal");
Review Comment:
This is good but it could be a separate PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
