kwin commented on code in PR #1394:
URL: https://github.com/apache/maven-release/pull/1394#discussion_r2491079937
##########
maven-release-manager/src/main/java/org/apache/maven/shared/release/DefaultReleaseManager.java:
##########
@@ -118,6 +118,11 @@ private void prepare(ReleasePrepareRequest prepareRequest,
ReleaseResult result)
// Create a config containing values from the session properties (ie
command line properties with cli).
ReleaseUtils.copyPropertiesToReleaseDescriptor(
prepareRequest.getUserProperties(), new
ReleaseDescriptorBuilder() {
+ public ReleaseDescriptorBuilder setPushChanges(boolean
pushChanges) {
+ builder.setPushChanges(pushChanges);
+ return this;
+ }
+
Review Comment:
I think instead of just evaluating some magic properties we should introduce
a mojo parameter (with a property) in
https://github.com/apache/maven-release/blob/master/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PrepareReleaseMojo.java.
That way it is also nicely documented in
https://maven.apache.org/maven-release/maven-release-plugin/prepare-mojo.html.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
