AlexanderAshitkin commented on PR #395:
URL:
https://github.com/apache/maven-build-cache-extension/pull/395#issuecomment-3465729676
Hi
1. I'm trying to understand why `verifyCacheConsistency` is even impacted.
The verification logic only checks tracked properties from a user-defined
configuration. So, `module-version` is not tracked by default, and should not
interfere with this verification logic. Why is it causing issues in this case?
Is it tracked in the impacted cache configuration?
```java
boolean isParamsMatched(
MavenProject project, MojoExecution mojoExecution, Mojo mojo,
CompletedExecution completedExecution) {
List<TrackedProperty> tracked =
cacheConfig.getTrackedProperties(mojoExecution);
for (TrackedProperty trackedProperty : tracked) {
```
2. Version is an unstable input and should not interfere with the cache.
Versions are normalized elsewhere, and if Maven 4 introduced such logic for
this specific property, I would prefer to have the value normalized to a
standard value `<VERSION>` or, at the cache level, completely excluded from the
reconciliation process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
