desruisseaux commented on code in PR #985:
URL:
https://github.com/apache/maven-compiler-plugin/pull/985#discussion_r2459711611
##########
src/it/default-fork-windows/pom.xml:
##########
@@ -30,14 +30,6 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
</properties>
- <dependencies>
- <dependency>
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <version>3.8.2</version>
- </dependency>
- </dependencies>
-
Review Comment:
With above proposal to keep some dependency to a testing framework (any of
them), it could be:
```xml
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-api</artifactId>
<version>5.14.0</version>
<scope>test</scope>
</dependency>
```
Or any other version of JUnit, or any other testing framework. The important
thing is to have something with the `test` scope.
Note: I'm not sure why `<scope>test</scope>` was not present in the previous
version of this test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
