Pankraz76 commented on issue #238:
URL: https://github.com/apache/maven-parent/issues/238#issuecomment-3410310624
> and calling it `unused` would be wrong imho.
Yes, also allowed to be called `ignored` then.
In this case — actually, also in general, imho — that might be a better
approach because it’s always intentional when done so.
> I’m not saying we shouldn’t try to improve or fix our code (when there’s
actually something to improve). But maybe PMD is too old and there are better
alternatives. What about SpotBugs?
Old but gold, just like this tool.
Both have their reasons to be used. SpotBugs, imho, is even “older,” but
it’s working — that’s the point. Coming from PMD, I can see the Prone community
is much more active due to Google and the Picnic fork.
Check is all all about code quality, of course, using all of them right now
including Rewrite. There’s only one tool missing, which is Spotless — then
Checkstyle is having every possible tool I even know of ^^.
I can confirm PMD sometimes passes, but then SpotBugs really finds
something. It always feels like there’s something *really* wrong, as it has to
pass PMD’s error rules — which are good defaults for a reason, just like in
Prone’s case.
Long story short, I’d suggest going with Prone for finding some stuff. It’s
not doing any harm like @elharo would see the rewriting or called patching in
this context. Its just analysis, like we’re used to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
