gnodet commented on PR #959: URL: https://github.com/apache/maven-compiler-plugin/pull/959#issuecomment-3405935607
I'm not sure about generating subprojects dynamically. Subprojects are subjects to lifecycles, plugin binding, etc... I'm not sure we really want to go that way. I guess some experiments are needed, but the easiest will probably to revert the additional check I mentioned and let `jar`, `sources` and `javadoc` generate multiple artifacts under various groupId/artifactId. > For being more specific: > > * The Maven Compiler plugin has only one main output: the `target/classes` directory. This output can be used directly by any Java tools having a `--module-path` argument, such as `java` and `javadoc`, but not `jar` (well… `jar` also has a `--module-path` argument, but used only for hashing). > * The JAR plugin could generate dynamically one sub-project per Java module, and each dynamically generated sub-project has its own generated `pom.xml` and one single main artefact. > > The dynamic sub-projects would be generated by the JAR plugin because `jar` is the Java tools which is not multi-module. Most other Java tools are multi-module. It makes sense that JAR is not multi-module, because it makes smaller files to download. > > Even in a non-JPMS world, the view that the JAR plugin should not do much more than just zipping everything in the `target/classes/` directory may be obsolete anyway. See for example [apache/maven-jar-plugin#484](https://github.com/apache/maven-jar-plugin/issues/484). I'm not really sure we need to create subprojects dynamically. If it's just the jar. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
