dheeraj1010 opened a new pull request, #1623:
URL: https://github.com/apache/maven-resolver/pull/1623
## Description
This PR modernizes the Maven Resolver codebase by replacing manual resource
management patterns with Java 7's try-with-resources statements. The changes
eliminate verbose try-catch-finally blocks while improving code safety and
readability.
## Changes Made
### Files Modified:
- **`maven-resolver-test-util/TestFileProcessor.java`**
- Refactored `write(File, String)`, `write(File, InputStream)`, and
`copy(File, File, ProgressListener)` methods
- Converted FileOutputStream and BufferedOutputStream to try-with-resources
- **`maven-resolver-test-util/TestFileUtils.java`**
- Refactored `copyFile()`, `readBytes()`, `writeBytes()`, `readProps()`,
and `writeProps()` methods
- Converted FileInputStream, FileOutputStream, BufferedOutputStream, and
RandomAccessFile to try-with-resources
- **`maven-resolver-test-http/HttpServer.java`**
- Updated HTTP request handling methods
- Converted FileInputStream and FileOutputStream to try-with-resources
- **`maven-resolver-test-util/DependencyGraphParser.java`**
- Refactored `parse(URL)` method
- Converted BufferedReader to try-with-resources
- **`maven-resolver-test-util/IniArtifactDataReader.java`**
- Updated BufferedReader usage with proper resource management
## Benefits
✅ **Cleaner Code**: Eliminates verbose try-catch-finally blocks
✅ **Better Resource Management**: Automatic resource cleanup with
try-with-resources
✅ **Reduced Error-Prone Code**: Lower risk of resource leaks
✅ **Modern Java Practices**: Adopts Java 7+ features appropriately
✅ **Improved Readability**: More concise and easier to understand code
## Before/After Example
**Before:**
```java
FileOutputStream fos = null;
try {
fos = new FileOutputStream(file);
if (data != null) {
fos.write(data.getBytes(StandardCharsets.UTF_8));
}
fos.close();
fos = null;
} finally {
try {
if (fos != null) {
fos.close();
}
} catch (final IOException e) {
// Suppressed due to an exception already thrown in the try block.
}
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
