Pankraz76 commented on code in PR #11284:
URL: https://github.com/apache/maven/pull/11284#discussion_r2436639005
##########
api/maven-api-xml/src/main/java/org/apache/maven/api/xml/XmlNode.java:
##########
@@ -533,16 +533,16 @@ private String toStringObject() {
}
private static <T> boolean addToStringField(
- StringBuilder sb, T o, Function<T, Boolean> p, String n,
boolean w) {
Review Comment:
I have no idea what’s happening here, and honestly, I don’t want to know. I
just want to read an API and understand its reasoning right away — without
relying on random and unnecessary implementation details that no one cares
about. It’s supposed to be about functionality, obviously.
This code is highly coupled and has almost no cohesion. It’s a good example
of why you shouldn’t use single-character variable names. I consider this API
broken because it fails to convey its intent clearly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
