jira-importer commented on issue #243: URL: https://github.com/apache/maven-war-plugin/issues/243#issuecomment-2967855300
**[breilly](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=breilly)** commented I think either my report was misunderstood or I'm misunderstanding the response. This problem isn't about choosing which file to take from multiple war overlays. It's about whether to use a file from a war overlay or from the project depending on that war. I agree that overrides should not depend on a timestamp. The problem that I reported was the result of code that does use timestamp checks. The patch that I attached removes the timestamp check for the case that I ran into. I should note that there are other uses of copyFileIfModified() in that file that I did not review to see if they should also be changed. Also, I haven't checked to see if the code has changed since I reported the bug. In general, the code seemed backwards to me. It was copying the current project's files and then trying to choose the right files to copy from the dependency (which is where the timestamp check seemed to come in, though even that doesn't quite make sense). A safer way to do it would be to copy the files from the dependency and then copy the current project's files on top, replacing anything that existed in the dependency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
