jira-importer commented on issue #248:
URL: 
https://github.com/apache/maven-war-plugin/issues/248#issuecomment-2967855721

   **[Dennis 
Lundberg](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=denn...@apache.org)**
 commented
   
   I like this feature, but I think that the configuration should be done 
differently.
   
   The approach in the patch isn't open to extension by other potential 
implementations of matchers. May I suggest a single String parameter containing 
the name for the matching strategy implementation. We could have 
`packagingMatchingStrategy=standard` or `packagingMatchingStrategy=normal` for 
the current behavior, then `packagingMatchingStrategy=regexp` and 
`packagingMatchingStrategy=negatableRegexp` for the new features.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to