jira-importer commented on issue #271: URL: https://github.com/apache/maven-war-plugin/issues/271#issuecomment-2967857416
**[Stephane Nicoll](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=snicoll)** commented Piotr, I added some nice helpers to test the overlay functionality. I have written 3 very simple tests but they tests quite everything (content of the webapp, text file content, content completeness that is it tests that only the specified files are there). It would be nice if we could port all your tests to this technique (see WarOverlaysTest, note that the wars are generated automatically from the content of src/test/resources/overlays/XXX). I had a look to the code, I'd like to separate the logic in a manager. AbstractWarMojo contains way too much code. What about a WarTask just like in the assembly plugin (one task to handle an overlay, one task to copy the web resources, one task to copy the src/main/webapp content, etc). Are you going to work on it short term ? Let me know. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
