jira-importer commented on issue #184: URL: https://github.com/apache/maven-war-plugin/issues/184#issuecomment-2967848600
**[Kenney Westerhof](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=kenney)** commented Hi Allan, Nice patch, except for the solution. I guess you don't know this, but if you have 2 classes in a plugin, and one extends the other, both can have /** `@parameter` */ annotations - that works even for abstract base classes. I suggest you create an AbstractWarMojo baseclass, move all the common code (including setters/getters/fields/`@parameter` annotations) there, and let the mojo's extend that common baseclass. That way the 3 mojo's will be very small and will be more maintainable - f.i. adding a parameter now has impact at 3 classes, when you use the abstract base class there's just one class to modify, etc.. Thanks a lot! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
