jira-importer commented on issue #217: URL: https://github.com/apache/maven-war-plugin/issues/217#issuecomment-2967853455
**[Brett Porter](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=brettporter)** commented I have applied this, but would like further revision: - need an index.html - introduction should be usage.html - replace 'm2' with 'mvn' in examples - incorrect formatting of <<\<packaging>>> - version of 1.0-SNAPSHOT, not 0.0 which is not a very sensible example - instead of talking about modes, talk about "use cases": * WAR as a packaging type * building a WAR from the command line (note that they need to have previously run package to compile classes, etc) * building an exploded WAR from the command line (note that they need to have previously run package to compile classes, etc) * building a WAR in place from the command line - remove defaults at bottom of page - the reference page lists these (and will be improved later) - better explanatory text at the top (the part about it being error prone is irrelevant - nobody does things by hand in Maven) - use \<code style> for things like pom.xml, WEB-INF/lib, target/..., etc - remove the example for putting inplace in the pom, it makes no sense - for the directory diagrams, consider using 'tree': available for cygwin here: http://lassauge.free.fr/cygwin/release/ - be careful with boilerplating documents. Some of these have inconsistencies that have been copy+pasted. - the example links are broken - choose shorter, more concise names for the examples - FAQ should be a normal menu item, not a header. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
