jira-importer commented on issue #203:
URL: 
https://github.com/apache/maven-war-plugin/issues/203#issuecomment-2967852446

   **[Michal 
Domagala](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=michaldo)**
 commented
   
   I take a look on code and it seems to me that in 
org.apache.maven.plugin.war.overlay.OverlayManager.getOverlaysAsArtifacts() 
(https://github.com/apache/maven-plugins/blob/trunk/maven-war-plugin/src/main/java/org/apache/maven/plugin/war/overlay/OverlayManager.java#L244)
 line
   
   `final Set<Artifact> artifacts = project.getArtifacts();`
   
   should be replaced (conditionally) by
   
   `final Set<Artifact> artifacts = project.getDependencyArtifacts();`
   
   I don't see any usecase why transitive dependent WARs should be taken as 
overlay, because they are already included in direct dependent WARs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to