jira-importer commented on issue #160: URL: https://github.com/apache/maven-war-plugin/issues/160#issuecomment-2967846739
**[Kenney Westerhof](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=kenney)** commented What I really like to see is the removal of warSourceDirectory. It should be just a resource directory, specified in a \<resource> section, with a different \<targetPath> (the exploded war dir, not the WEB-INF/classes dir or even the classes/ dir), or something like that. THe resources plugin should take care of copying it. Here's a nice solution (I think): Add a new mojo to the war plugin and bind it to a pre process-resources phase. That mojo will take care of registering the (still existing) warSource directory as a resource root. When process-resources is up, the resources plugin will pick that directory up and copy it, applying filtering. The problem here is how to specify filtering - we don't want to do that in more than one place, if possible: everything in MNG-788 would be duplicated for the configuration of this mojo then.. So we could specify the warSource directory as in a \<resource> section too, where filtering can be specified. It should somehow be marked as being the warSourceDirectory, for instance if the \<directory> matches the warSourceDirectory configuration (src/main/webapp). If there are no matches, the new mojo will have created a resource section with default values. If there exists one or more matching resource sections, a problem can be that targetPath is specified - what if it doesn't match the temporary exploded webapp directory in target/ ? If targetPath is not specified, the mojo will set the targetPath to the warSourceDirectory (for matching resource sections!). normal resources go in target/classes, these should go in the exploded webapp root (not in WEB-INF/classes either). Or there might be another, more general way to mark the resource for use of a specific plugin.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
