jira-importer commented on issue #96: URL: https://github.com/apache/maven-war-plugin/issues/96#issuecomment-2967842063
**[Fabrice Bellingard](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=fabemn)** commented Mike, I think Chuck is right. There should be 2 parameters: * one that filters files when they are copied from the source project (i.e. ${basedir}) to the exploded project (i.e. ${project.build.directory}/${project.build.finalName}) * this is useful, for instance, if you want to exclude JARs stored in the SCM under WEB-INF/lib * IMHO, this one should be the **warSourceExcludes** (as it used to work for version 2.0) * one that filters files when they are packaged from the exploded project to the WAR archive * this is useful when you want to do your skinny WAR * this one could be called **warExcludes**, as Chuck said Considering this, the patch applied for -[MWAR-39](http://jira.codehaus.org/browse/MWAR-39)- is not correct because it uses the same parameter to do both filtering. What's more, what is confusing is that "warSourceIncludes" has an alias, so people don't know that they are actually modifying the same parameter : ``` ... /** * The comma separated list of tokens to exclude from the WAR. * * @parameter alias="excludes" */ private String warSourceExcludes; ... ``` We have to work on that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
