[
https://issues.apache.org/jira/browse/MDEPLOY-205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17965825#comment-17965825
]
Olivier Lamy commented on MDEPLOY-205:
--------------------------------------
This project has moved from Jira to GitHub Issues. This issue was migrated to
[apache/maven-deploy-plugin#367|https://github.com/apache/maven-deploy-plugin/issues/367].
> MavenProject with only attachments must have packaging "pom"
> ------------------------------------------------------------
>
> Key: MDEPLOY-205
> URL: https://issues.apache.org/jira/browse/MDEPLOY-205
> Project: Maven Deploy Plugin (Moved to GitHub Issues)
> Issue Type: Improvement
> Reporter: Robert Scholte
> Assignee: Robert Scholte
> Priority: Major
> Fix For: 3.0.0-M1
>
>
> According to {{svn blame}} MDEPLOY-78 is responsible for this piece of code:
> {code}
> if ( isPomArtifact )
> {
> deployableArtifacts.add( artifact );
> }
> else
> {
> File file = artifact.getFile();
> if ( file != null && file.isFile() )
> {
> deployableArtifacts.add( artifact );
> }
> else if ( !attachedArtifacts.isEmpty() )
> {
> getLog().info( "No primary artifact to deploy, deploying
> attached artifacts instead." );
> Artifact pomArtifact =
> artifactFactory.createProjectArtifact(
> artifact.getGroupId(), artifact.getArtifactId(),
>
> artifact.getBaseVersion() );
> pomArtifact.setFile( pomFile );
> if ( request.isUpdateReleaseInfo() )
> {
> pomArtifact.setRelease( true );
> }
> deployableArtifacts.add( pomArtifact );
> // propagate the timestamped version to the main artifact
> for the attached artifacts to pick it up
> artifact.setResolvedVersion( pomArtifact.getVersion() );
> }
> else
> {
> String message = "The packaging for this project did not
> assign a file to the build artifact";
> throw new MojoExecutionException( message );
> }
> }
> {code}
> I don't like the {{else if}}-clause. IMHO if there's no main artifact, the
> packaging should simply be 'pom'.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
