jira-importer opened a new issue, #683:
URL: https://github.com/apache/maven-indexer/issues/683

   **[Matthias 
Bläsing](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=mblaesing)**
 opened 
**[MINDEXER-157](https://issues.apache.org/jira/browse/MINDEXER-157?redirect=false)**
 and commented
   
   I investigated a regression introduced into the NetBeans codebase by the 
update of maven indexer to 6.2.0 
(https://github.com/apache/netbeans/issues/4102) It turned out, that maven 
indexer after loading the index needs to explicitly rebuild the group lists as 
they are not stored with the index any longer. Rebuilding on demand is not an 
option for us, so a solution using a cached version was tried.
   
   The idea is, that after the index is updated, the current group lists will 
be dumped into cache files and when the index is loaded from scratch, that 
cache is used to initialize all groups and root groups. This seemed to work ok, 
but the results were strange - only the root groups were returned. Debugging 
showed, that the all groups list was very short (~950 groups for maven central) 
while the root groups list was very long (~66.000 groups for maven central). 
The opposite ratio was expected.
   
   The issue can be traced into _DefaultIndexUpdater#loadIndexDirectory_ where 
_IndexingContext#replace_ is called with the with the wrong order or 
parameters. The declared method:
   
   ```java
   public interface IndexingContext {
       void replace( Directory directory, Set<String> allGroups, Set<String> 
rootGroups ) throws IOException;
   }
   ```
   
   is called as:
   
   ```java
   private Date loadIndexDirectory( final IndexUpdateRequest updateRequest, 
final ResourceFetcher fetcher,
                                    final boolean merge, final String 
remoteIndexFile )
       throws IOException
   {
       // ...
               updateRequest.getIndexingContext().replace( directory, 
rootGroups, allGroups );
       // ...
   }
   ```
   
   The last two parameters need to be reversed.
   
   
   ---
   
   **Remote Links:**
   - [GitHub Pull Request #211
   ](https://github.com/apache/maven-indexer/pull/211)
   - [GitHub Pull Request #4193
   ](https://github.com/apache/netbeans/pull/4193)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to