[ 
https://issues.apache.org/jira/browse/SCM-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17963465#comment-17963465
 ] 

ASF GitHub Bot commented on SCM-869:
------------------------------------

jira-importer commented on issue #1105:
URL: https://github.com/apache/maven-scm/issues/1105#issuecomment-2964646137

   **[Michael 
Osipov](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=michael-o)**
 commented
   
   The `list` function has been introduced with SCM-183 12 years ago with 
b158cf35d05271942a10bbef564366ab6a3059ad. I have checked few other providers. 
They have been incorrectly implemented also. The Git provider has been 
incorrectly implemented eversince with `git ls-files`.
   
   I think this birth issue can only be properly resolved with 2.0.0.
   
   Can you actually raise this general issue on the dev mailing list? I'd be 
interested in other devs opinion. I don't might incorrect code altogether or 
change the Javadoc if this is a better way.
   




> gitexe list() implemented incorrectly
> -------------------------------------
>
>                 Key: SCM-869
>                 URL: https://issues.apache.org/jira/browse/SCM-869
>             Project: Maven SCM (Moved to GitHub Issues)
>          Issue Type: Bug
>          Components: maven-scm-provider-gitexe
>    Affects Versions: 1.9.5, 1.10.0
>            Reporter: Ilya Basin
>            Assignee: Michael Osipov
>            Priority: Major
>             Fix For: 1.10.0
>
>
> Taking the Svn implementation as a model, ScmProvider.list() should be 
> implemented as follows:
>  * The command must directly query the remote repository for files
>  * A local working copy is unnecessary and if it doesn't exist, the remote 
> repository must not be checked out.
>  * fileSet.getBasedir() indicates where to run the scm binary. The 
> recommended value is ".".
>  * fileSet.getFileList() indicates the files to list
>  * repository indicates the repo URL
> Git (among other SCMs) does not support listing remote files, so the command 
> should just fail.
> For listing files in a working copy, users should call the 
> ScmProvider.status() method instead.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to