[ 
https://issues.apache.org/jira/browse/SCM-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17963339#comment-17963339
 ] 

ASF GitHub Bot commented on SCM-835:
------------------------------------

jira-importer opened a new issue, #1065:
URL: https://github.com/apache/maven-scm/issues/1065

   **[Eli 
Shvartsman](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=shvar)**
 opened 
**[SCM-835](https://issues.apache.org/jira/browse/SCM-835?redirect=false)** and 
commented
   
   We have a scenario, when we have to commit only one file, for example 
"LICENSE.md".
   
   When we use
   
   ```
   <includes>LICENSE.md</includes>
   ```
   
   GitCheckInCommand is invoking a GitStatusConsumer for fileSet.getBasedir() 
and if there are any changes, passes them to "commit" and "push" phases.
   
   If there are any other files changed (except LICENSE.md), than 
statusConsumer.getChangedFiles() is not empty and we proceed. But if we didn't 
made any changes to our file, "commit" phase will fail, as there is nothing to 
commit (in terms of our fileSet).
   
   I suppose to patch GitStatusConsumer, so it could be aware of fileSet and 
not give us status of changed files if they are not in a fileSet.
   
   
   ---
   
   **Affects:** 1.10.0
   
   **Remote Links:**
   - [GitHub Pull Request #51
   ](https://github.com/apache/maven-scm/pull/51)
   - [GitHub Pull Request #51
   ](https://github.com/apache/maven-scm/pull/51)
   




> includes directive doesn't work correctly when other files in directory 
> changes
> -------------------------------------------------------------------------------
>
>                 Key: SCM-835
>                 URL: https://issues.apache.org/jira/browse/SCM-835
>             Project: Maven SCM (Moved to GitHub Issues)
>          Issue Type: Bug
>          Components: maven-scm-provider-gitexe
>    Affects Versions: 1.10.0
>            Reporter: Eli Shvartsman
>            Assignee: Michael Osipov
>            Priority: Major
>             Fix For: 1.11.1
>
>
> We have a scenario, when we have to commit only one file, for example 
> "LICENSE.md".
> When we use 
> {code}
>                     <includes>LICENSE.md</includes>
> {code}
> GitCheckInCommand is invoking a GitStatusConsumer for fileSet.getBasedir() 
> and if there are any changes, passes them to "commit" and "push" phases.
> If there are any other files changed (except LICENSE.md), than 
> statusConsumer.getChangedFiles() is not empty and we proceed. But if we 
> didn't made any changes to our file, "commit" phase will fail, as there is 
> nothing to commit (in terms of our fileSet).
> I suppose to patch GitStatusConsumer, so it could be aware of fileSet and not 
> give us status of changed files if they are not in a fileSet.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to