jira-importer commented on issue #1050: URL: https://github.com/apache/maven-scm/issues/1050#issuecomment-2964642870
**[Michael Osipov](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=michael-o)** commented Sounds reasonable but there are more spots than this: ``` Name Line Text Path DiffMojo.java 94 FileUtils.fileWrite( outputFile.getAbsolutePath(), result.getPatch() ); D:\Entwicklung\Projekte\maven-scm\maven-scm-plugin\src\main\java\org\apache\maven\scm\plugin IntegrityDiffCommand.java 90 // a NPE in org.codehaus.plexus.util.FileUtils.fileWrite(FileUtils.java:426) D:\Entwicklung\Projekte\maven-scm\maven-scm-providers\maven-scm-provider-integrity\src\main\java\org\apache\maven\scm\provider\integrity\command\diff AbstractCvsCheckInCommand.java 73 FileUtils.fileWrite( messageFile.getAbsolutePath(), message ); D:\Entwicklung\Projekte\maven-scm\maven-scm-providers\maven-scm-providers-cvs\maven-scm-provider-cvs-commons\src\main\java\org\apache\maven\scm\provider\cvslib\command\checkin GitCheckInCommand.java 74 FileUtils.fileWrite( messageFile.getAbsolutePath(), message ); D:\Entwicklung\Projekte\maven-scm\maven-scm-providers\maven-scm-providers-git\maven-scm-provider-gitexe\src\main\java\org\apache\maven\scm\provider\git\gitexe\command\checkin GitTagCommand.java 80 FileUtils.fileWrite( messageFile.getAbsolutePath(), scmTagParameters.getMessage() ); D:\Entwicklung\Projekte\maven-scm\maven-scm-providers\maven-scm-providers-git\maven-scm-provider-gitexe\src\main\java\org\apache\maven\scm\provider\git\gitexe\command\tag SvnBranchCommand.java 79 FileUtils.fileWrite( messageFile.getAbsolutePath(), scmBranchParameters.getMessage() ); D:\Entwicklung\Projekte\maven-scm\maven-scm-providers\maven-scm-providers-svn\maven-scm-provider-svnexe\src\main\java\org\apache\maven\scm\provider\svn\svnexe\command\branch SvnCheckInCommand.java 63 FileUtils.fileWrite( messageFile.getAbsolutePath(), message ); D:\Entwicklung\Projekte\maven-scm\maven-scm-providers\maven-scm-providers-svn\maven-scm-provider-svnexe\src\main\java\org\apache\maven\scm\provider\svn\svnexe\command\checkin SvnMkdirCommand.java 60 FileUtils.fileWrite( messageFile.getAbsolutePath(), message ); D:\Entwicklung\Projekte\maven-scm\maven-scm-providers\maven-scm-providers-svn\maven-scm-provider-svnexe\src\main\java\org\apache\maven\scm\provider\svn\svnexe\command\mkdir SvnTagCommand.java 103 FileUtils.fileWrite( messageFile.getAbsolutePath(), scmTagParameters == null ? "" : scmTagParameters D:\Entwicklung\Projekte\maven-scm\maven-scm-providers\maven-scm-providers-svn\maven-scm-provider-svnexe\src\main\java\org\apache\maven\scm\provider\svn\svnexe\command\tag ``` and `SvnCommandLineUtils#addTarget`. We need a more general approach because this is used through entire Maven SCM. One can either add `messageEncoding` with default value `UTF-8` or reuse these maybe: ```xml <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding> ``` At least we need a stable encoding because this is internal code. `UTF-8` is the safest bet here. See [here](http://stackoverflow.com/a/19886198/696632) for similar problems with Subversion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
