jira-importer commented on issue #979:
URL: https://github.com/apache/maven-scm/issues/979#issuecomment-2964637093

   **[Gary L 
Peskin](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=ga...@firstech.com)**
 commented
   
   I've attached a proposed patch file.  In getting further into this issue, I 
decided against using the "`-z`" option because it does not have each file on a 
separate line and switching to using it would cause too big of a change in the 
flow that drives the `GitStatusConsumer.consumeLine` method which is oriented 
towards a _line_ of output.
   
   Instead, I detect when the "`--porcelain`" output is surrounded by quotation 
marks and I dequote it in a manner consistent with the way that Git quoted it.
   
   The other main change was to get away from treating the file name as a URI 
since it is not a URI.  A filename can contain characters that are not allowed 
in a URI and trying to treat a filename as a relative URI is not a good fit.
   
   Please review this and let me know what you think and if additional 
revisions are required.
   
   Thanks.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to