[jira] [Commented] (SCM-351) generated client spec name fails if there is a space or tilde in directory name

[ASF GitHub Bot (Jira)]

    [ 
https://issues.apache.org/jira/browse/SCM-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17961137#comment-17961137
 ] 

ASF GitHub Bot commented on SCM-351:
------------------------------------

jira-importer commented on issue #570:
URL: https://github.com/apache/maven-scm/issues/570#issuecomment-2964604616

   **[zak 
jacobson](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=zoosnack)**
 commented
   
   Here is the output.
   
   ```
   [DEBUG] Updating clientspec:
   Client: johndoe-SDGL04301175-MavenSCM-C:\Perforce 
Workspace\foundation\target\checkout
   Root: C:\Perforce Workspace\foundation\target\checkout
   Owner: johndoe
   
   View:
           /... //johndoe-SDGL04301175-MavenSCM-C:\Perforce 
Workspace\foundation\target\checkout/...
   Description:
           Created by maven-scm-provider-perforce
   
   [ERROR] Unable to sync.  Are you logged in?
   ```
   
   




> generated client spec name fails if there is a space or tilde in directory 
> name
> -------------------------------------------------------------------------------
>
>                 Key: SCM-351
>                 URL: https://issues.apache.org/jira/browse/SCM-351
>             Project: Maven SCM (Moved to GitHub Issues)
>          Issue Type: Bug
>          Components: maven-scm-provider-perforce
>    Affects Versions: 1.0
>            Reporter: zak jacobson
>            Assignee: Emmanuel Venisse
>            Priority: Major
>             Fix For: 1.1
>
>
> The default generated client spec name is calculated in 
> generateDefaultClientspecName() as:
>    username + "−" + hostname + "−MavenSCM−" + path;
> if path includes a space or tilde, the client spec is not created and the 
> plugin fails to sync.
> Can:
> {noformat}path = workDir.getCanonicalPath().replace( '/', '\\' ){noformat} 
> be replaced with:
> {noformat}path = workDir.getCanonicalPath().replace( '/', '\\' 
> ).replaceAll("[ ~]", "-"){noformat} 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)