[
http://jira.codehaus.org/browse/DOXIA-169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_111396
]
Lukas Theussl commented on DOXIA-169:
-------------------------------------
I've had a quick look at this patch and have some issues:
* first, please adhere to our coding conventions, in particular, no tabs, no
System.out/err
* the EOL string is available to the ConfluenceParser through the Markup
interface, it should also be available to the BlockParser
* a confluence linebreak element should produce a sink lineBreak(), not an EOL.
Ie, your test input
{noformat}
Line\\
break.
{noformat}
should produce the following TextSink output:
{noformat}
begin:paragraph
text: Line
lineBreak
text: break.
end:paragraph
{noformat}
instead of
{noformat}
begin:paragraph
text: Line
break.
end:paragraph
{noformat}
* last but not least: in the future I will refuse to apply any patch that has
the doxia tree checked out under a directory called 'crap'... ;)
> Confluence module does not recognize line breaks (\\)
> -----------------------------------------------------
>
> Key: DOXIA-169
> URL: http://jira.codehaus.org/browse/DOXIA-169
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Confluence
> Affects Versions: 1.0-alpha-8
> Reporter: Dave Syer
> Attachments: linebeak-patch.txt
>
>
> Confluence module does not recognize line breaks (\\)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
