adangel commented on code in PR #2403:
URL: https://github.com/apache/maven/pull/2403#discussion_r2135367232
##########
pom.xml:
##########
@@ -793,13 +793,22 @@ under the License.</licenseText>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-pmd-plugin</artifactId>
- <dependencies>
- <dependency>
- <groupId>net.sourceforge.pmd</groupId>
- <artifactId>pmd-core</artifactId>
- <version>7.14.0</version>
- </dependency>
- </dependencies>
+ <configuration>
+ <analysisCache>true</analysisCache>
+
<analysisCacheLocation>${maven.multiModuleProjectDirectory}/.pmd/.cache</analysisCacheLocation>
+ <printFailingErrors>true</printFailingErrors>
+ <rulesets>
+
<ruleset>${maven.multiModuleProjectDirectory}/.pmd/ruleset.xml</ruleset>
+ </rulesets>
+ </configuration>
+ <executions>
+ <execution>
+ <goals>
+ <goal>check</goal>
+ </goals>
+ <phase>verify</phase>
Review Comment:
I think specifying the phase is not necessary, as the plugin by default
binds to "verify" anyway.
##########
pom.xml:
##########
@@ -1176,5 +1189,19 @@ under the License.</licenseText>
</plugins>
</build>
</profile>
+ <profile>
+ <id>pmd</id>
+ <activation>
+ <activeByDefault>true</activeByDefault>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-pmd-plugin</artifactId>
+ </plugin>
+ </plugins>
+ </build>
+ </profile>
Review Comment:
Is this profile still required given that the plugin is no enabled by
default (above lines 828..)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
