Pankraz76 commented on code in PR #2376:
URL: https://github.com/apache/maven/pull/2376#discussion_r2104757933
##########
compat/maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultUpdateCheckManager.java:
##########
@@ -303,7 +301,7 @@ private Properties read(File touchfile) {
Properties props = new Properties();
try (FileInputStream in = new FileInputStream(touchfile)) {
- try (FileLock lock = in.getChannel().lock(0,
Long.MAX_VALUE, true)) {
+ try (FileLock ignored = in.getChannel().lock(0,
Long.MAX_VALUE, true)) {
Review Comment:
@desruisseaux point out correctly that its used `indirectly`, having the
implizit `close()` call.
As IDEA and PMD both point this out is seems ok to rename to give proper
context. Its ignored as handled by default.
Other way should be an inline comment for suppression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
