[
https://issues.apache.org/jira/browse/MDEP-931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17952863#comment-17952863
]
ASF GitHub Bot commented on MDEP-931:
-------------------------------------
Ndacyayisenga-droid opened a new pull request, #530:
URL: https://github.com/apache/maven-dependency-plugin/pull/530
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Your pull request should address just one issue, without pulling in
other changes.
- [ ] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
Note that commits might be squashed by a maintainer on merge.
- [ ] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
- [ ] Run `mvn verify` to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> AbstractSerializingVisitor should not use PrintWriter
> -----------------------------------------------------
>
> Key: MDEP-931
> URL: https://issues.apache.org/jira/browse/MDEP-931
> Project: Maven Dependency Plugin (Moved to GitHub Issues)
> Issue Type: Improvement
> Reporter: Elliotte Rusty Harold
> Priority: Minor
>
> See https://github.com/apache/maven-dependency-plugin/pull/391/files
> AbstractSerializingVisitor uses a PrintWriter which swallows exceptions. It
> should use a regular Writer instead.
> This is exposed in the protected API so fixing this is ugly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
