hgschmie commented on code in PR #2350:
URL: https://github.com/apache/maven/pull/2350#discussion_r2096701934


##########
compat/maven-compat/src/main/java/org/apache/maven/repository/metadata/MetadataGraphEdge.java:
##########
@@ -30,9 +30,9 @@
 public class MetadataGraphEdge {
     String version;
     ArtifactScopeEnum scope;
-    int depth = -1;
-    int pomOrder = -1;
-    boolean resolved = true;
+    int depth;

Review Comment:
   removing those is wrong. Currently, calling "getPomOrder()" in a subclass 
constructor (which is called from super()) will return -1. After this change, 
it will return 0. 
   
   This is not just a simple cleanup, but changing the actual logic of the 
class.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to