Pankraz76 commented on code in PR #2326:
URL: https://github.com/apache/maven/pull/2326#discussion_r2086763458
##########
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java:
##########
@@ -38,65 +37,54 @@
import org.apache.maven.plugin.descriptor.io.PluginDescriptorStaxReader;
import org.apache.maven.plugin.descriptor.io.PluginDescriptorStaxWriter;
-import static org.apache.maven.impl.ImplUtils.nonNull;
import static org.apache.maven.impl.StaxLocation.getLocation;
import static org.apache.maven.impl.StaxLocation.getMessage;
@Named
@Singleton
public class DefaultPluginXmlFactory implements PluginXmlFactory {
+
+ static final PluginDescriptorStaxWriter WRITER = new
PluginDescriptorStaxWriter();
+ static final PluginDescriptorStaxReader READER = new
PluginDescriptorStaxReader();
+
@Override
public PluginDescriptor read(@Nonnull XmlReaderRequest request) throws
XmlReaderException {
- nonNull(request, "request");
- Path path = request.getPath();
- URL url = request.getURL();
- Reader reader = request.getReader();
- InputStream inputStream = request.getInputStream();
- if (path == null && url == null && reader == null && inputStream ==
null) {
- throw new IllegalArgumentException("path, url, reader or
inputStream must be non null");
- }
+ READER.setAddDefaultEntities(request.isAddDefaultEntities());
+ var req = request.validateReadability();
Review Comment:
Moving domain specific logic, to its origin where its dedicated to and
designated from; making context clear; giving second purpose to be reused.
imho a good example for OOP:
https://en.wikipedia.org/wiki/Object-oriented_programming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
