Pankraz76 commented on code in PR #2287:
URL: https://github.com/apache/maven/pull/2287#discussion_r2083319519
##########
impl/maven-core/src/main/java/org/apache/maven/execution/MavenSession.java:
##########
@@ -423,13 +422,13 @@ private static Settings
adaptSettings(MavenExecutionRequest request) {
.localRepository(localRepo != null ?
localRepo.getAbsolutePath() : null)
.interactiveMode(request.isInteractiveMode())
.offline(request.isOffline())
-
.proxies(request.getProxies().stream().map(Proxy::getDelegate).collect(Collectors.toList()))
-
.servers(request.getServers().stream().map(Server::getDelegate).collect(Collectors.toList()))
-
.mirrors(request.getMirrors().stream().map(Mirror::getDelegate).collect(Collectors.toList()))
+
.proxies(request.getProxies().stream().map(Proxy::getDelegate).toList())
+
.servers(request.getServers().stream().map(Server::getDelegate).toList())
+
.mirrors(request.getMirrors().stream().map(Mirror::getDelegate).toList())
.profiles(request.getProfiles().stream()
.map(Profile::getDelegate)
.map(SettingsUtilsV4::convertToSettingsProfile)
- .collect(Collectors.toList()))
Review Comment:
this is api
##########
impl/maven-xml/src/main/java/org/apache/maven/internal/xml/DefaultXmlService.java:
##########
@@ -312,7 +312,7 @@ public XmlNode doMerge(XmlNode dominant, XmlNode recessive,
Boolean childMergeOv
Iterator<XmlNode> it =
commonChildren.computeIfAbsent(name, n1 ->
Stream.of(dominant.children().stream()
.filter(n2 ->
n2.name().equals(n1))
- .collect(Collectors.toList()))
Review Comment:
okay, internal.
##########
impl/maven-core/src/main/java/org/apache/maven/execution/MavenSession.java:
##########
@@ -423,13 +422,13 @@ private static Settings
adaptSettings(MavenExecutionRequest request) {
.localRepository(localRepo != null ?
localRepo.getAbsolutePath() : null)
.interactiveMode(request.isInteractiveMode())
.offline(request.isOffline())
-
.proxies(request.getProxies().stream().map(Proxy::getDelegate).collect(Collectors.toList()))
-
.servers(request.getServers().stream().map(Server::getDelegate).collect(Collectors.toList()))
-
.mirrors(request.getMirrors().stream().map(Mirror::getDelegate).collect(Collectors.toList()))
Review Comment:
thats okay as internal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
