anthonyvdotbe commented on issue #109: URL: https://github.com/apache/maven-clean-plugin/issues/109#issuecomment-2825142388
Just to be clear: I'm all in favor of migrating to `Path`. I'm just arguing that this issue is a severe regression and that we should revert the problematic commits and release version 3.4.2 ASAP. Parallel to that, a new PR can be created (for which you can just revert the reverted commits again and add tests to it to prevent any regressions like this one). #243 is not merged yet, so it could just be rebased on the new PR. > Instead, I propose to add a `force` configuration option similar to `rm -f` in Unix. I suggest that the default value should be `false` for safety and for consistency with the standard usage in Unix commands. If agreed, I can volunteer for adding this option on top of [#243](https://github.com/apache/maven-clean-plugin/pull/243). The new behavior is a regression that breaks long-standing behavior. So I believe the priority should be on fixing the regression. Besides that, I fail to see why anyone would want to use such a configuration option with the value `false`? Anyway, if such an option were to be introduced, its default value should match the way it has always behaved, so `true`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
