desruisseaux commented on code in PR #2219:
URL: https://github.com/apache/maven/pull/2219#discussion_r2052285482


##########
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependencyResolverResult.java:
##########
@@ -102,19 +102,27 @@ public class DefaultDependencyResolverResult implements 
DependencyResolverResult
      * to {@link #addDependency(Node, Dependency, Predicate, Path)}.
      *
      * @param request the corresponding request
-     * @param cache cache of module information about each dependency
      * @param exceptions the exceptions that occurred while building the 
dependency graph
      * @param root the root node of the dependency graph
      * @param count estimated number of dependencies
      */
     public DefaultDependencyResolverResult(
+            DependencyResolverRequest request, List<Exception> exceptions, 
Node root, int count) {
+        this(request, new PathModularizationCache(), exceptions, root, count);
+    }
+
+    DefaultDependencyResolverResult(
             DependencyResolverRequest request,
             PathModularizationCache cache,
             List<Exception> exceptions,
             Node root,
             int count) {
         this.request = request;
-        this.cache = cache;
+        if (cache == null) {

Review Comment:
   The new constructor should replace all the calls to the previous constructor 
with a null cache. We are sure that the new constructor is invoked outside the 
package since the old constructor became package-private. So we only need to 
ensure that the calls inside the package pass a non-null cache, and I think 
that it is already the case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to