elharo commented on code in PR #144:
URL:
https://github.com/apache/maven-dependency-analyzer/pull/144#discussion_r2050648282
##########
src/main/java/org/apache/maven/shared/dependency/analyzer/asm/ConstantPoolParser.java:
##########
@@ -208,7 +208,7 @@ private static String decodeString(ByteBuffer buf) {
// Explicit cast for compatibility with covariant return type on JDK
9's ByteBuffer
Review Comment:
Good point. If this doesn;t fail (and it doesn't) we're missing a test or
the comment is no longer true. Hmm, I think that comment applies to line 210
which uses the return type rather than 211 which doesn't but let me double
check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
