[
https://issues.apache.org/jira/browse/MNG-7046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17943756#comment-17943756
]
Tamas Cservenak commented on MNG-7046:
--------------------------------------
I am on edge to disagree with all this decision done here (and probably revert
the whole thing).
This sentence "at no time the client should be able to inject an incomplete
repository which can lead to various side effects" makes me assume we talk
about (today) newly implemented feature: MNG-8654 (merged to master). This
feature _prevents_ Maven to call Resolver with "incomplete repositories" (and
artifact and all), that was possible before, and did happen, ranging from user
errors, like using mis-typed property for artifact version, and Resolver
blindly going for artifact URL with placeholder in its URI, to even using
baseURL with un-interpolated property. This mentioned feature now {_}prevents
all those cases{_}. Maven is now unable to invoke Resolver with anything that
is not properly interpolated (and again, it may be user error, or even config
error, but whatever it is, fails the build).
IF this was the single only reason to implement this feature, and take away
otherwise powerful feature of interpolation from repository URL, I'd call this
-1.
> Revert MNG-5639 and make repo config static only (no ${param} interpolation)
> ----------------------------------------------------------------------------
>
> Key: MNG-7046
> URL: https://issues.apache.org/jira/browse/MNG-7046
> Project: Maven
> Issue Type: Task
> Components: Artifacts and Repositories, Dependencies
> Affects Versions: 3.6.3
> Reporter: Michael Osipov
> Priority: Major
>
> As discussed in MNG-5639 repositories should always be known upfront, they
> have to be static to avoid chicken and egg situations, a project should not
> influence settings. It should be the way around.
> In subsequent ticket it will be verified that repo configuration does not
> contain any expression:
> https://github.com/apache/maven/commit/d411c3fa98832e7d86d901fe86ff63ba907cf868#commitcomment-44782281.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
