Re: [PR] [MNG-8674] Deprecate mergeId in the Maven 3 model and remove it in the new model [maven]

[via GitHub]

elharo commented on code in PR #2233:
URL: https://github.com/apache/maven/pull/2233#discussion_r2029850419

##########
api/maven-api-model/src/main/mdo/maven.mdo:
##########
@@ -2220,6 +2220,21 @@
         </field>
       </fields>
       <codeSegments>
+        <codeSegment>
+            <version>4.0.0+</version>
+            <code>
+            <![CDATA[
+    @Deprecated

Review Comment:
   So these are new methods being added in a deprecated state? That's unusual.
   
   There should be a Javadoc comment about them of some kind, perhaps just 
indicating that they should not be used at all.
   
   And if they're deprecated because they're only for internal use, that's not 
really what deprecated is typically used for.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org