gnodet commented on code in PR #2218:
URL: https://github.com/apache/maven/pull/2218#discussion_r2026273743
##########
api/maven-api-core/src/main/java/org/apache/maven/api/ExtensibleEnums.java:
##########
@@ -66,37 +107,73 @@ public String toString() {
}
}
+ /**
+ * Implementation of the PathScope interface.
+ */
private static class DefaultPathScope extends DefaultExtensibleEnum
implements PathScope {
private final ProjectScope projectScope;
private final Set<DependencyScope> dependencyScopes;
+ /**
Review Comment:
This whole class is package protected and the classes are even private.
Ideally they'd be refactored as records. And they'd become a one line record
definition (we may need the toString though).
Having them top-level classes make them more visible (not in the java
sense), and I don't think they need to be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
