jira-importer commented on issue #393:
URL: 
https://github.com/apache/maven-deploy-plugin/issues/393#issuecomment-2771536982

   **[Stephen 
Connolly](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=stephenc)**
 commented
   
   So IIUC the issue here is where you are using the release plugin **and** 
building every commit.
   
   Thus when you build the release commit in between where the mainline has 
SNAPSHOTS you try to deploy, but without the correct deploy goals and may miss 
deployment artifact’s as well as potentially fail if you collide with artifacts 
from the actual release build.
   
   I agree that is problematic, But it’s problematic because of choices made by 
the user that Maven cannot know about.
   
   I’m now 2+ years following a pattern where **every** commit on master is a 
release build with the Maven release plugin... but we never push the master 
branch back, rather throw it away... we push the tag back though... and this is 
**awesome**... no longer do we have diffs on the master branch... with that 
choice of how to do CI this is not an issue
   
   Similarly, it would be trivial to write a “guard” plugin that sets a system 
property if the current version is not a SNAPSHOT. Thus you could run `mvn 
guard:check deploy` from the CI server and have `guard:check` set the skip 
properties for install and deploy plugins...
   
   OTOH if we we want to add config here as this ticket is suggesting then we 
should be complete and add a property to skip deploying SNAPSHOTS as well as 
one to skip releases... and add same properties to the install plugin
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to