jira-importer commented on issue #359: URL: https://github.com/apache/maven-deploy-plugin/issues/359#issuecomment-2771534127
**[Robert Scholte](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=rfscholte)** commented [DeployMojo](http://maven.apache.org/plugins/maven-deploy-plugin/xref/org/apache/maven/plugin/deploy/DeployMojo.html#L155) refers to the code you're talking about. I did a quick scan and to me the code seems correct and doesn't match your story. ``` if ( skip ) { getLog().info( "Skipping artifact deployment" ); } else { // not interesting for this case } boolean projectsReady = readyProjectsCounter.incrementAndGet() == reactorProjects.size(); if ( projectsReady ) { synchronized ( deployRequests ) { while ( !deployRequests.isEmpty() ) { deployProject( deployRequests.remove( 0 ) ); } } } else if ( addedDeployRequest ) { getLog().info( "Deploying " + project.getGroupId() + ":" + project.getArtifactId() + ":" + project.getVersion() + " at end" ); } ``` Skip only logs, the plugin still does the check if it has reached the final project. Are you sure that it works when `skip=false` ? This might look like a weird question, but there are edge-cases where `deployAtEnd` doesn't work due to the architecture of Maven Core and which can't be fixed by the maven-deploy-plugin. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
