gnodet commented on code in PR #25:
URL: 
https://github.com/apache/maven-xinclude-extension/pull/25#discussion_r2014930874


##########
src/main/java/org/apache/maven/xinclude/stax/XIncludeStreamReader.java:
##########
@@ -70,9 +71,19 @@
 @SuppressWarnings("checkstyle:MissingSwitchDefault")
 class XIncludeStreamReader extends StreamReaderDelegate {
 
-    private static final String XINCLUDE_NAMESPACE = 
"http://www.w3.org/2001/XInclude";;
-    private static final String XINCLUDE_INCLUDE = "include";
-    private static final String XINCLUDE_FALLBACK = "fallback";
+    public static final String XINCLUDE_NAMESPACE = 
"http://www.w3.org/2001/XInclude";;
+    public static final String XINCLUDE_INCLUDE_ELEMENT = "include";
+    public static final String XINCLUDE_FALLBACK_ELEMENT = "fallback";
+    public static final String XINCLUDE_LOCAL_ATTRIBUTES = 
"http://www.w3.org/2001/XInclude/local-attributes";;
+    public static final String XINCLUDE_HREF_ATTRIBUTE = "href";
+    public static final String XINCLUDE_PARSE_ATTRIBUTE = "parse";
+    public static final String XINCLUDE_XPOINTER_ATTRIBUTE = "xpointer";
+    public static final String XINCLUDE_FRAGID_ATTRIBUTE = "fragid";
+    public static final String XINCLUDE_SET_XML_ID_ATTRIBUTE = "set-xml-id";

Review Comment:
   They are defined by the XINclude spec: see 
https://www.w3.org/TR/xinclude-11/#include_element



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to