[
https://issues.apache.org/jira/browse/MNG-8646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak updated MNG-8646:
---------------------------------
Description:
As it turned out, ITs were not using Mimir as they redefined Maven Central to
allow snapshots, and that made Mimir not handle the IT used Maven Central
(while those did not contain snapshots, it was still pointing at canonical URL).
Fixing this revealed several other (related or unrelated) issues:
* MavenProject was NPE prone regarding remote repositories handling
* MappedList was NPE prone regarding null values (emitted by MavenProject
remote repositories)
* several ProjectModelBuilder (detailed below) had no remote repositories set
anymore (as central is not in super POM anymore)
* some ITs revaled ReactorReader issues as well
org.apache.maven.project.DefaultProjectBuilder issues:
* model request type CONSUMER_PARENT is used for non-locally built projects
(ie. plugins invoked with direct mojo invocation), this seems strange. This
skips CI friendly replacement for example as shows in Maven ITs
* remote repositories are injected ONLY when injecting lifecycle plugins
(processPlugins=true). This was ok when root pom was defining default
repository, but that's not the case anymore, and this results in projects built
that has 0 remote reposes.
At the end of the day, all issues were fixed but one IT that we declared
"invalid" was disabled (w/ remark about why's).
was:
As it turned out, ITs were not using Mimir as they redefined Maven Central to
allow snapshots, and that made Mimir not handle the IT used Maven Central
(while those did not contain snapshots, it was still pointing at canonical URL).
Fixing this revealed several other (related or unrelated) issues:
* MavenProject was NPE prone regarding remote repositories handling
* MappedList was NPE prone regarding null values (emitted by MavenProject
remote repositories)
* several ProjectModelBuilder (detailed below) had no remote repositories set
anymore (as central is not in super POM anymore)
* some ITs revaled ReactorReader issues as well
org.apache.maven.project.DefaultProjectBuilder issues:
* model request type CONSUMER_PARENT is used for non-locally built projects
(ie. plugins invoked with direct mojo invocation), this seems strange. This
skips CI friendly replacement for example as shows in Maven ITs
* remote repositories are injected ONLY when injecting lifecycle plugins
(processPlugins=true). This was ok when root pom was defining default
repository, but that's not the case anymore, and this results in projects built
that has 0 remote reposes.
> Make IT tests use "outer" Mimir caching as well
> -----------------------------------------------
>
> Key: MNG-8646
> URL: https://issues.apache.org/jira/browse/MNG-8646
> Project: Maven
> Issue Type: Bug
> Components: Core
> Reporter: Tamas Cservenak
> Priority: Major
> Fix For: 4.0.0-rc-4
>
>
> As it turned out, ITs were not using Mimir as they redefined Maven Central to
> allow snapshots, and that made Mimir not handle the IT used Maven Central
> (while those did not contain snapshots, it was still pointing at canonical
> URL).
> Fixing this revealed several other (related or unrelated) issues:
> * MavenProject was NPE prone regarding remote repositories handling
> * MappedList was NPE prone regarding null values (emitted by MavenProject
> remote repositories)
> * several ProjectModelBuilder (detailed below) had no remote repositories
> set anymore (as central is not in super POM anymore)
> * some ITs revaled ReactorReader issues as well
> org.apache.maven.project.DefaultProjectBuilder issues:
> * model request type CONSUMER_PARENT is used for non-locally built projects
> (ie. plugins invoked with direct mojo invocation), this seems strange. This
> skips CI friendly replacement for example as shows in Maven ITs
> * remote repositories are injected ONLY when injecting lifecycle plugins
> (processPlugins=true). This was ok when root pom was defining default
> repository, but that's not the case anymore, and this results in projects
> built that has 0 remote reposes.
> At the end of the day, all issues were fixed but one IT that we declared
> "invalid" was disabled (w/ remark about why's).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
