gnodet commented on PR #2176: URL: https://github.com/apache/maven/pull/2176#issuecomment-2744142559
> > > Formatting. But the change is too "big" IMO. Maybe just "if pom being built is from reactor, do not build consumer?". Still, that means the process plugins value is ignored? > > > > > > So m-assembly-p does [the following](https://github.com/apache/maven-assembly-plugin/blob/5c324065f129e4803196bdfedb6102c730a703b5/src/main/java/org/apache/maven/plugins/assembly/archive/task/AddDependencySetsTask.java#L169-L171) > > ```java > > return new DefaultProjectBuildingRequest(configSource.getMavenSession().getProjectBuildingRequest()) > > .setValidationLevel(ModelBuildingRequest.VALIDATION_LEVEL_MINIMAL) > > .setProcessPlugins(false); > > ``` > > > > > > > > > > > > > > > > > > > > > > > > so we need to remove both conditions, else it will have no effect. > > The actual problem is that there's no different made by m-assembly-p between loading a pom from the repository (as a consumer) and loading from the projects being built. Maybe that's the one that needs to be fixed ? > > I'm going to experiment with [apache/maven-assembly-plugin#217](https://github.com/apache/maven-assembly-plugin/pull/217) It seems to work locally for me. @cstamas could you double check when you have some time ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
