slawekjaranowski commented on PR #191: URL: https://github.com/apache/maven-compiler-plugin/pull/191#issuecomment-2711458373
> The PR descripations says > > > The generatedSourcesPath will still be added to the maven project paths. > > But this is not the case, the [entire code](https://github.com/apache/maven-compiler-plugin/pull/191/files#diff-d4bac42d8f4c68d397ddbaa05c1cbbed7984ef6dc0bb9ea60739df78997e99eeL842) related to source paths was removed. This means that downstream plugins no longer see the generated sources. For example, the source-jar will no longer contain the generated sources. I'm pretty sure that's not what you wanted and will upset anyone who relies on https://issues.apache.org/jira/browse/MCOMPILER-157. Wasn't the idea to only remove [this line](https://github.com/apache/maven-compiler-plugin/pull/191/files#diff-d4bac42d8f4c68d397ddbaa05c1cbbed7984ef6dc0bb9ea60739df78997e99eeL828)? That should have been enough to fix [MCOMPILER-538](https://issues.apache.org/jira/browse/MCOMPILER-538) without any side effects. Looks like missing tests for MCOMPILER-157 ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
