elharo commented on code in PR #113:
URL:
https://github.com/apache/maven-changes-plugin/pull/113#discussion_r1975351352
##########
src/main/java/org/apache/maven/plugins/changes/ChangesReport.java:
##########
@@ -75,6 +75,14 @@ public class ChangesReport extends AbstractChangesReport {
@Parameter(property = "changes.addActionDate", defaultValue = "false")
private boolean addActionDate;
+ /**
+ * Whether the changelog action text should be passed as raw text to the
Doxia sink or not.
+ *
+ * @since 3.0
+ */
+ @Parameter
+ private boolean passRawText;
Review Comment:
Is passRawText the best name for this parameter? It doesn't feel
self-evident to me. Perhaps we should go the other way. I.e. escapeText with a
default value of true. I'm not sure.
##########
src/main/java/org/apache/maven/plugins/changes/ChangesReport.java:
##########
@@ -75,6 +75,14 @@ public class ChangesReport extends AbstractChangesReport {
@Parameter(property = "changes.addActionDate", defaultValue = "false")
private boolean addActionDate;
+ /**
+ * Whether the changelog action text should be passed as raw text to the
Doxia sink or not.
Review Comment:
"raw text" should be defined here and an example added
also "changelog action" is a term I really had to think about, here and in
the code. Is there any more obvious name we can use for that? E.g. change
description?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
