jira-importer commented on issue #180: URL: https://github.com/apache/maven-clean-plugin/issues/180#issuecomment-2690264244
**[Peter De Maeyer](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=peterdm)** commented I created a PR for this, leveraging Java 7's new `Files` + `Path` API over the old `File` API. I also added a JUnit test covering the new code (changed lines) for 100%. Future improvements, out of scope of this issue: * For this issue, I limited the use of the `Files` + `Path` API to this very specific bit of code. It would be an improvement to migrate _all_ the code away from the legacy `File` API to the new `Files` + `Path` API. Not just for the Clean plugin, but for all Maven plugins. * Re-evaluate the need for the retries and especially the `Thread.sleep` in the `Cleaner` class, and solve the problem (if any) differently. Expecting that those who introduced it would have written a test to illustrate the use case, I temporarily removed the `Thread.sleep` to see which test would fail, which would give me an indication of why the code needs to be there, but all tests just passed. So I'm still clueless why that hack was introduced in the first place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
