jira-importer commented on issue #132:
URL: 
https://github.com/apache/maven-clean-plugin/issues/132#issuecomment-2690258787

   **[Nick 
Pellow](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=npellow)** 
commented
   
   I saw MCLEAN-33, and it is not fine grained or flexible enough.
   ie - the clean plugin can either delete all default directories, or none.
   
   I considered excluding the default directories from cleaning, and then using 
the filesets parameter. The problems with this approach however are:
   1. users are required to have duplicate configuration (ie - the build 
directory locations) in their pom.xml
   2. the maven-clean-plugin will need to be added to the users pom
   
   Allowing a simple String to be used, instead of a Collection, allows the 
patterns to be passed in on the command line.
   
   ```
   -Dexcludes=**/expensive.file1
   ```
   
   It also allows other plugins (this is my use case), which are bound to the 
pre-clean phase to set this property on the project to avoid specific files 
being deleted when clean is run.
   
   I agree that this usage is somewhat inconsistent. You would have to agree 
however, that it is extremely practical.
   
   IMO, maven should support splitting of comma and space separated Strings 
into Collection parameters automatically. This is exactly what Ant does. It 
would make the pom a lot more readable, and allow passing of collection 
arguments on the command line.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to