[
https://issues.apache.org/jira/browse/MRESOLVER-680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930259#comment-17930259
]
ASF GitHub Bot commented on MRESOLVER-680:
------------------------------------------
cstamas commented on code in PR #659:
URL: https://github.com/apache/maven-resolver/pull/659#discussion_r1969496415
##########
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultArtifactPredicateFactory.java:
##########
@@ -51,7 +51,7 @@ public final class DefaultArtifactPredicateFactory implements
ArtifactPredicateF
public static final String CONFIG_PROP_OMIT_CHECKSUMS_FOR_EXTENSIONS =
CONFIG_PROPS_PREFIX + "omitChecksumsForExtensions";
- public static final String DEFAULT_OMIT_CHECKSUMS_FOR_EXTENSIONS =
".asc,.sigstore";
+ public static final String DEFAULT_OMIT_CHECKSUMS_FOR_EXTENSIONS =
".asc,.sigstore.json";
Review Comment:
Just like in referenced GPG PR, I'd leave both: `.sigstore` and
`.sigstore.json`.
> Disable checksum by default for .sigstore.json instead of .sigstore
> -------------------------------------------------------------------
>
> Key: MRESOLVER-680
> URL: https://issues.apache.org/jira/browse/MRESOLVER-680
> Project: Maven Resolver
> Issue Type: Improvement
> Components: Resolver
> Affects Versions: 2.0.6
> Reporter: Thomas Leplus
> Priority: Major
> Fix For: 1.9.23, 2.0.7
>
>
> The need for this change was confirmed with sigstore team in this
> [discussion|https://github.com/sigstore/sigstore-java/issues/905#issuecomment-2677275304].
> This change was already done in [Maven GPG
> plugin|https://issues.apache.org/jira/browse/MGPG-130].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
