[
https://issues.apache.org/jira/browse/MSITE-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus reassigned MSITE-1033:
--------------------------------------
Assignee: Konrad Windszus
> AbstractDeployMojo.getTopLevelProject(Project) returns wrong project for SCM
> URLs
> ---------------------------------------------------------------------------------
>
> Key: MSITE-1033
> URL: https://issues.apache.org/jira/browse/MSITE-1033
> Project: Maven Site Plugin
> Issue Type: Bug
> Components: site:stage(-deploy)
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Major
>
> The method {{getTopLevelProject(project)}}
> (https://github.com/apache/maven-site-plugin/blob/5a0e56d30c716821f922b9ee0981cda28284578f/src/main/java/org/apache/maven/plugins/site/deploy/AbstractDeployMojo.java#L508)
> returns the wrong project when all projects in the hierarchy have a
> "DistributionManagement->Site->URL" leveraging the SCM URL format:
> https://maven.apache.org/scm/scm-url-format.html (e.g.
> scm:git:g...@github.com:codehaus-plexus/plexus-sec-dispatcher.git/). The
> method internally relies on
> https://github.com/apache/maven-doxia-sitetools/blob/9af3a745919525481e96bb4f0c18d62cf41446b4/doxia-site-model/src/main/java/org/apache/maven/doxia/site/inheritance/URIPathDescriptor.java#L191
> which returns
> bq. true if ... shares the same scheme, host and port with the given URI.
> For example
> https://github.com/codehaus-plexus/plexus-sec-dispatcher/blob/master/pom.xml
> inherits from
> https://github.com/codehaus-plexus/plexus-pom/blob/master/pom.xml but for
> sure both projects don't share a common site. However the latter is returned
> as top project as
> {{scm:git:https://github.com/codehaus-plexus/plexus-pom.git/}} and
> {{scm:git:g...@github.com:codehaus-plexus/plexus-sec-dispatcher.git/}} are
> incorrectly assumed to be the same because this URI is being parsed as
> # host = null
> # scheme = "scm"
> # port = -1
> (this is an opaque URI according to
> https://docs.oracle.com/javase/8/docs/api/java/net/URI.html#isOpaque--)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
