elharo commented on code in PR #680: URL: https://github.com/apache/maven-site/pull/680#discussion_r1949481856
########## content/apt/guides/mini/guide-encryption.apt: ########## @@ -83,6 +83,8 @@ mvn --encrypt-master-password <password> </settingsSecurity> +------------------------------------+ + <The encrypted version of the master password is encrypted with a {{{https://github.com/apache/maven/blob/fe25a2627c1dafeb44188dad9f45dfd5fe965a98/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java#L856}hardcoded key}}, so please treat it as if the password is stored in the file in plain text.> Review Comment: This must be a different version of the API than I'm seeing. On https://codehaus-plexus.github.io/plexus-cipher/apidocs/org/codehaus/plexus/components/cipher/internal/DefaultPlexusCipher.html there are three arguments to encryptAndDecorate, not two; and the second is the string to be encrypted. Or maybe I'm looking at the wrong class completely? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org