[
https://issues.apache.org/jira/browse/MCOMPILER-608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923540#comment-17923540
]
ASF GitHub Bot commented on MCOMPILER-608:
------------------------------------------
SentryMan opened a new pull request, #275:
URL: https://github.com/apache/maven-compiler-plugin/pull/275
Disable reproducible ASM module-info transformation when on JDK 22+
Following this checklist to help us incorporate your
contribution quickly and easily
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MCOMPILER) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Format the pull request title like `[MCOMPILER-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MCOMPILER-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licensed under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> Reproducible builds break compilation on --release 23+
> -------------------------------------------------------
>
> Key: MCOMPILER-608
> URL: https://issues.apache.org/jira/browse/MCOMPILER-608
> Project: Maven Compiler Plugin
> Issue Type: Bug
> Affects Versions: 3.13.0
> Reporter: Josiah Noel
> Priority: Major
>
> As a result of MCOMPILER-542, it seems that when compiling with a release
> higher than 22 and the `project.build.outputTimestamp` property set,
> compilation fails because of `Unsupported class file major version`.
> Since [[JDK-8318913]|https://bugs.openjdk.org/browse/JDK-8318913] was added
> to the JDK in 22, would it be sufficient to modify the logic that if the
> current JVM is 22+, the ASM transformation should not occur? This can be
> achieved with various methods (checking SourceVersion.values(), using
> reflection to call Runtime.version() if available, etc.)
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
